Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dispatch of close events for badges #1027

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

geoextra
Copy link
Contributor

@geoextra geoextra commented Aug 31, 2023

πŸ“‘ Description

The documented example for close events on a dismissable Badge is currently not working. The code from the docs is:

<script>
  import { Badge } from 'flowbite-svelte';

  function handleClose(event) {
    alert('Badge dismissed');
  }
</script>

<Badge dismissable large on:close={handleClose}>Default</Badge>

Furthermore, the close event still needs to be added to the documentation.

Status

  • [] Not Completed
  • Completed

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

@stackblitz
Copy link

stackblitz bot commented Aug 31, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Aug 31, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 31, 2023 9:27pm
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 31, 2023 9:27pm

@jjagielka
Copy link
Contributor

Agree the docs must be updated as dismiss event is renamed to close, but the example works fine.
Dismissable badges

@shinokada shinokada marked this pull request as ready for review September 3, 2023 13:14
@shinokada shinokada merged commit 876c193 into themesberg:main Sep 3, 2023
4 checks passed
shinokada added a commit to shinokada/flowbite-svelte that referenced this pull request Sep 3, 2023
shinokada added a commit to shinokada/flowbite-svelte that referenced this pull request Sep 3, 2023
shinokada added a commit that referenced this pull request Sep 3, 2023
* feat: add $$props.classDialog to Modal

* docs: update modal page

* fix: revert #1027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants