Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new API for Carousel #1032

Merged
merged 5 commits into from
Sep 6, 2023
Merged

feat: new API for Carousel #1032

merged 5 commits into from
Sep 6, 2023

Conversation

jjagielka
Copy link
Contributor

@jjagielka jjagielka commented Sep 3, 2023

📑 Description

New API - the first approach

To do:

  • some optimization
  • props generation
  • docs detailed text

Please do comment.

Status

  • Not Completed
  • Completed

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

ℹ Additional Information

@stackblitz
Copy link

stackblitz bot commented Sep 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Sep 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2023 8:48pm
flowbite-svelte-update ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2023 8:48pm

@shinokada
Copy link
Collaborator

shinokada commented Sep 4, 2023

It looks good.
Is the right plus sign in the Advanced customization example intentional?
If so, ChervonDoubleRightSolid is better than a plus sign.

image

@shinokada
Copy link
Collaborator

Can you run pnpm lib-helpers and put back <CompoAttributesViewer {components}/>?

@jjagielka
Copy link
Contributor Author

Is the right plus sign in the Advanced customization example intentional? If so, ChervonDoubleRightSolid is better than a plus sign.

I wanted to insert nice icon, but you were changing flowbite-svelte-icons so I was unsure how to use it yet.

@jjagielka
Copy link
Contributor Author

@shinokada - I don't understand that error. Seems deployment went well.

Comment about lib-helpers:
It extracts events from files, but it extracts also events that are not forwarded. So if you have on:click={handler}, it's getting extracted even though it shouldn't.
And if you have on:click={handler} on:click to add the forward, then two on:click are getting extracted.

@shinokada
Copy link
Collaborator

I was fixing svelte-lib-helper. It is my bad. Can you update dependencies and run pnpm lib-helpers.

@shinokada
Copy link
Collaborator

I just update the package.json.

@shinokada
Copy link
Collaborator

If it is completed, I can resolve the conflicts and squash/merge.

@shinokada
Copy link
Collaborator

Is it possible to add this function, #899?

@jjagielka jjagielka deleted the carousel branch September 10, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants