fix: background context should affect only dark background in Textarea #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Can you show me screenshots of what are different in the |
|
I thought my description was clear - if the "background" context is set (which |
|
Here is a screenshot of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 7 places where
getContext('background')is used -Checkbox,Input,InputAddon,Radio,Textarea,ToggleandToolbarButton. In all of them exceptTextareathis context only slightly changes color of some aspect in dark mode. But inTextareait also changesbg-gray-50tobg-white.Removed that switch to be consistent with other components. (And in
ToolbarButtonjust moved the same class from a conditional statement.)