Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransisionFrame #1145

Merged
merged 2 commits into from
Nov 4, 2023
Merged

TransisionFrame #1145

merged 2 commits into from
Nov 4, 2023

Conversation

jjagielka
Copy link
Contributor

πŸ“‘ Description

Transition support in Frame component caused some unwanted side effects.
This PR separates the transitions into new component TransitionFrame which is now a base for Alert, Badge, Toast.

TransitionFrame inherits from Frame adding the dismiss functionality: transitioning disappearing, open / close event, programmable open control.

Alert, Badge, Toast - adapted to use TransitionFrame

API for components not changed, so docs untouched.

This should address #1144 - please check.

Status

  • Not Completed
  • Completed

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

Copy link

stackblitz bot commented Nov 4, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Nov 4, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 4, 2023 9:25am
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 4, 2023 9:25am

@metafab
Copy link

metafab commented Nov 24, 2023

Hello, do you know when a new release integrating this fix will be published?

I noticed the problem happened when accessing a store. Do you know why?

@shinokada
Copy link
Collaborator

I just published a new version, v0.44.20.

@metafab
Copy link

metafab commented Nov 24, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants