-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjust eslint configuration to eslint-plugin-svelte (previously used eslint-plugin-svelte3) #1310
Conversation
.idea/ contains project settings for WebStorm IDE
β¦used eslint-plugin-svelte3)
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
WalkthroughThis update enhances the configuration for handling Svelte files in the project by specifying a new parser and extending ESLint recommendations. Additionally, it improves the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Files skipped from review due to trivial changes (1)
Additional comments not posted (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@pasevin Will this work for Svelte 3? |
This shouldn't cause any issues for Svelte 3. |
π Description
I wanted to contribute to this repository, but once I opened
![image](https://private-user-images.githubusercontent.com/40219331/322925429-32fc7a9e-4c74-4431-90b1-de7bd418bdfe.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA2OTkzMTEsIm5iZiI6MTcyMDY5OTAxMSwicGF0aCI6Ii80MDIxOTMzMS8zMjI5MjU0MjktMzJmYzdhOWUtNGM3NC00NDMxLTkwYjEtZGU3YmQ0MThiZGZlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzExVDExNTY1MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJlNGEzM2I1YzA2ZWY5ZTJkMGNhZTQ4ZmM1YTdiZTRjMDA3YjllOThlMzdmZDczYzk1OTU2OGE3ZmNhZTkzNjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.e84jB1MQVNkQvFjnbBYNe6OiRqDXzUnjdC01_dEH5yw)
.svelte
file I noticed an eslint error:The issue was introduced with this commit deec07e which changed eslint plugin from
eslint-plugin-svelte3
toeslint-plugin-svelte
. At that time.eslintrc.cjs
wasn't updated accordingly.side note: using
.eslintrc.js
is deprecated (see https://eslint.org/docs/latest/use/configure/configuration-files)About linting files in general:
lint
script never executeseslint
asprettier
fails with 163 files not matching standards (99.9% of them are not formatted json files)eslint
is executed, it raises102 problems
At the time all of the issues (pretter, eslint) are solved I'd suggest adding https://github.com/lint-staged/lint-staged (along with husky precommit hook) that will format & lint staged files (it will make sure all files committed to this repository follow the same rules)
I've also added
.idea/
to.gitignore
which stores local project configuration while using WebStorm IDEStatus
β Checks
Summary by CodeRabbit
Refactor
Chores
.gitignore
to exclude the.idea/
directory, enhancing project cleanliness.