Form buttons #167
Merged
Form buttons #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for the PR. It has been merged. |
|
Please create a PR when you complete Radio in dropdown and Checkbox in dropdown Thank you for your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
Form buttons: Radio, Checkbox, Toggle rewritten again.
I can't make the svelte component 'inheritance' work well so needed another code structure.
Svelte compiler is strict in checking the binding and does not allow
bind:checkedtoinput type="radio".On the other hand there's a known svelte bug of not properly handling
bind:groupforinput type="checkbox"when it's wrapped in the custom component.The above prevents in practice the usage of one file all input types support.
This PR adds as well a follow
disableto the label component so it is not needed to handle that in checkbox or radio.Toggle is just a special case of checkbox and is implemented as
<Checkbox custom={true} ....✅ Checks
ℹ Additional Information
on:clickis not omitted this time.