Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forms-buttons: missing examples and tuning #169

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

jjagielka
Copy link
Contributor

πŸ“‘ Description

  • Added Radio in dropdown and Checkbox in dropdown
  • Format adjustments to Search example in Dropdown
  • Dropdown - floating menu added Radio/Checkbox prefixes to sections.
  • Some other polishing here and there

Flowbite introduces anomaly of dark colors when forms are put on another component. This is visible when Checkbox or Radio is put on Dropdown for example. That's why I've added tinted property to those.
I needed to add tinted property to SimpleSearch for the same reason.

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • My pull request is based on the latest commit/version

β„Ή Additional Information

@vercel
Copy link

vercel bot commented Jul 20, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
flowbite-svelte βœ… Ready (Inspect) Visit Preview Jul 20, 2022 at 10:32PM (UTC)
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview Jul 20, 2022 at 10:32PM (UTC)

@shinokada
Copy link
Collaborator

shinokada commented Jul 21, 2022

Thank you for the PR. I will merge it soon.

I noticed you use $$restProps.class.
Generally I use $$props.class if there is one section.
If I want to add class to divClass, I use $$props.classDiv.
(for labelClass, $$props.classLabel, etc)
What do you think?

shinokada added a commit that referenced this pull request Jul 21, 2022
@shinokada shinokada merged commit 81e2303 into themesberg:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants