Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed more typos and website layout #182

Merged
merged 5 commits into from
Jul 23, 2022
Merged

Conversation

Hetarth02
Copy link
Contributor

πŸ“‘ Description

Fixed small typo in Getting Started and How to Contribute pages of the documentation.

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • My pull request is based on the latest commit/version

@vercel
Copy link

vercel bot commented Jul 23, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
flowbite-svelte βœ… Ready (Inspect) Visit Preview Jul 23, 2022 at 9:59AM (UTC)
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview Jul 23, 2022 at 9:59AM (UTC)

@Hetarth02
Copy link
Contributor Author

As I go through documentation, I will try to find and edit the typos I find but it will take me some time in doing this.

@shinokada
Copy link
Collaborator

Thank you for finding the typos.
Can you push more commits to this PR when you find the typos?
I will then merge it.
Thanks again.

@Hetarth02
Copy link
Contributor Author

Sure will do.

Website content has now more visibility than before.
@Hetarth02
Copy link
Contributor Author

I have fixed the website layout somewhat after reviewing your changes. Here is a before-after comparison,

Before, the entirety of the content was not showing(especially in footer) even after your changes.

image

image

After, now it is much more breathable and the content is fully visible.

image

image

@shinokada You can merge these changes for now as currently the website somewhat hinders user's readability, I will open a new PR which will contain fixed typos.

Hope you find these changes helpful!

@Hetarth02 Hetarth02 changed the title Fixed more typos Fixed more typos and website layout Jul 23, 2022
@shinokada shinokada merged commit 914c1f9 into themesberg:main Jul 23, 2022
@shinokada
Copy link
Collaborator

shinokada commented Jul 23, 2022

Thanks. Merged to v0.22.10.
I'm getting an error in the deployment. I need to check it.

image

@shinokada
Copy link
Collaborator

Ok, it is successfully deployed. Thank you for the PR.

@shinokada
Copy link
Collaborator

image

I think there is too much padding on the left than right for the main.
Can you have a look at this?

@Hetarth02
Copy link
Contributor Author

Hetarth02 commented Jul 23, 2022

Yeah, sure. Let me check and update you on this.
@shinokada Can you give me your device and browser specifications?
Because it is displaying everything in proper order on my side,

image

@shinokada
Copy link
Collaborator

shinokada commented Jul 23, 2022

macOS Monterey, version 12.4
Brave, Chrome, and FF. (latest version)

@Hetarth02
Copy link
Contributor Author

I rechecked my code, but I couldn't find anything. I think the issue might be regarding responsiveness on large screens(large screens as defined by tailwind). I think the issue might be originating from this bit.

Commit Link

image

Can you try changing the lg:pl-80 to something smaller like lg:pl-32 or lg:pl-48. I hope this would fix the issue.

@shinokada
Copy link
Collaborator

Ok, thanks. I will do it.

@shinokada
Copy link
Collaborator

Can you try the following in your system?

<main class="flex mx-auto mb-8 px-2 pt-16 lg:pl-72 2xl:pl-32">

And let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants