Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Megamenu #184

Merged
merged 4 commits into from
Jul 24, 2022
Merged

Megamenu #184

merged 4 commits into from
Jul 24, 2022

Conversation

jjagielka
Copy link
Contributor

📑 Description

Mega menu component.

<Megamenu/> is a standard visible component and its floating and visibility is managed by the `.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • My pull request is based on the latest commit/version

ℹ Additional Information

I've tried to add all the necessary links, declarations, types, etc., but probably I've missed something.

There's a strange error and the doc page megamenu/index.md gets narrower then expected from time to time. I don't know how to fix that.

@vercel
Copy link

vercel bot commented Jul 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
flowbite-svelte ✅ Ready (Inspect) Visit Preview Jul 24, 2022 at 4:09PM (UTC)
flowbite-svelte-update ✅ Ready (Inspect) Visit Preview Jul 24, 2022 at 4:09PM (UTC)

@shinokada
Copy link
Collaborator

Thank you for the PR.

  1. Can you check the position for the default mega menu and the mega menu with icons?

Flowbite
image

Flowbite-Svelte
image

Flowbite
image

Flowbite-Svelte
image

  1. Menu item style

Flowbite
image

Flowbite-Svelte
image

Menu items in a mega menu li should not have the class but li>a should have the class hover:underline hover:text-blue-600 dark:hover:text-blue-500.

@jjagielka
Copy link
Contributor Author

Should be good to run npm run gen:props to refresh all the recent changes.

@shinokada shinokada merged commit caa1f13 into themesberg:main Jul 24, 2022
@shinokada
Copy link
Collaborator

Thank you for the fix. Merged.

@shinokada shinokada mentioned this pull request Jul 24, 2022
5 tasks
@shinokada
Copy link
Collaborator

Added megamenuLayout, megamenuBlock and updated the props.
Please set export variables at the top, before a function.

Thank you for your hard work.

@shinokada
Copy link
Collaborator

@jjagielka Thank you for your continuous contribution. Your contribution is a great help.

Is it possible to inform the component you want to work by adding a short comment in the issue?
Then we can avoid duplicate work.

@jjagielka jjagielka deleted the megamenu branch July 27, 2022 17:38
@shinokada
Copy link
Collaborator

shinokada commented Jul 28, 2022

@jjagielka Can you have a look at this issue?
Mega menu is centered in a small screen.

Flowbite
image

http://localhost:8000/mega-menu#Mega_menu_with_icons
image

image

image

image

@shinokada
Copy link
Collaborator

@jjagielka Can you have a look at item type error?

image

@shinokada
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants