Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cards #186

Merged
merged 7 commits into from
Jul 26, 2022
Merged

Cards #186

merged 7 commits into from
Jul 26, 2022

Conversation

jjagielka
Copy link
Contributor

📑 Description

Cards module re-written. Previously Card component was too specialized with all those headers, texts, etc.
Currently it's up to the user to manage the text space.

Several examples updated / added. Some examples like e-commers, login, price should not be here as too complicated and they should be rather part of the blocks section.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • My pull request is based on the latest commit/version

ℹ Additional Information

@vercel
Copy link

vercel bot commented Jul 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
flowbite-svelte ✅ Ready (Inspect) Visit Preview Jul 26, 2022 at 0:30AM (UTC)
flowbite-svelte-update ✅ Ready (Inspect) Visit Preview Jul 26, 2022 at 0:30AM (UTC)

@shinokada
Copy link
Collaborator

Thanks. I will merge it soon and I will fix index pages.

@shinokada shinokada merged commit edd24b0 into themesberg:main Jul 26, 2022
@jjagielka jjagielka deleted the cards branch July 27, 2022 17:40
@shinokada
Copy link
Collaborator

shinokada commented Jul 31, 2022

When you have time, please have a look at the following item.

When I use 4 starts for E-commerce card, the last star size is different from others.

https://flowbite-svelte.com/cards#E-commerce_card

image

@jjagielka
Copy link
Contributor Author

This is feature of ‘svelte-heros’ package. Icons in solid variant are smaller then the outline ones.
Anyway, Card component uses the Rating component to render the stars. It has to e managed there.

@shinokada
Copy link
Collaborator

Thank you for the reply. I will have a look.

@shinokada
Copy link
Collaborator

You may notice this but I updated svelte-heros and the problem is solved.
shinokada/svelte-heros@ccf3c22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants