Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dropdown open/close api #219

Merged
merged 4 commits into from
Aug 15, 2022
Merged

fix: dropdown open/close api #219

merged 4 commits into from
Aug 15, 2022

Conversation

jjagielka
Copy link
Contributor

πŸ“‘ Description

Closes #217

  • Tooltip variable open changed to be exported
  • Dropdown - export open variable bind to Tooltip
  • doc added example how to control dropdown via open var

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

@vercel
Copy link

vercel bot commented Aug 14, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
flowbite-svelte βœ… Ready (Inspect) Visit Preview Aug 15, 2022 at 6:34AM (UTC)
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview Aug 15, 2022 at 6:34AM (UTC)

@shinokada
Copy link
Collaborator

shinokada commented Aug 14, 2022

Test failed with ReferenceError: window is not defined.

image

[WebServer] ReferenceError: window is not defined
    at fn (file:///Users/shinichiokada/Svelte/Flowbite-svelte/flowbite-svelte/.svelte-kit/output/server/_app/immutable/chunks/Tooltip-b0c2faaf.js:85:9)
    at Object.$$render (file:///Users/shinichiokada/Svelte/Flowbite-svelte/flowbite-svelte/.svelte-kit/output/server/_app/immutable/chunks/index-a3c8aff4.js:234:18)
    at fn (file:///Users/shinichiokada/Svelte/Flowbite-svelte/flowbite-svelte/.svelte-kit/output/server/_app/immutable/chunks/DropdownItem-69c4a269.js:45:60)

@shinokada
Copy link
Collaborator

Can we use onMount?

2 similar comments
@shinokada
Copy link
Collaborator

Can we use onMount?

@shinokada
Copy link
Collaborator

Can we use onMount?

@jjagielka
Copy link
Contributor Author

Try now.

@shinokada
Copy link
Collaborator

browser works for SvelteKit, but if user want to use Flowbite-Svelte on Svelte, it won't work.
Once I used it for another component and use ask me to make it Svelte compatible.

@jjagielka
Copy link
Contributor Author

OK. Browser removed.

@shinokada
Copy link
Collaborator

Thank you for a quick fix.
Merged.

@jjagielka jjagielka deleted the dropdown branch August 15, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close dropdown on click on dropdown item
2 participants