Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popper again #253

Merged
merged 4 commits into from
Aug 28, 2022
Merged

Popper again #253

merged 4 commits into from
Aug 28, 2022

Conversation

jjagielka
Copy link
Contributor

πŸ“‘ Description

Popper re-written. Breaking changes
Features:

  • decouple content from trigger - connection made via css query specified in triggeredBy parameter
  • multiple trigger elements possible - Popper can be re-used from different places in the document
  • use of the fade animation function from svelte instead of transition-opacity
  • use of svelte if directive instead of visible opacity classes
  • createPopper called only when content is open

Can you please do some testing before merge?
@AlessioGr can you check the behavior with SSR rendering?

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

Dropdown, Tooltip, Popover - old API left and some docs require further updates.

@vercel
Copy link

vercel bot commented Aug 28, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
flowbite-svelte βœ… Ready (Inspect) Visit Preview Aug 28, 2022 at 9:34PM (UTC)
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview Aug 28, 2022 at 9:34PM (UTC)

@shinokada
Copy link
Collaborator

Since you are adding events on line 90, you don't need line from 111 to 114?

@jjagielka
Copy link
Contributor Author

Line 90 adds the events to triggers i.e. buttons that will open/close the popup.
Line 111 to 114 are the events set on the popup it's self. This is needed when activeContent is set, to support moving or clicking the popup window. This is the major difference between Tooltip and Popover. In Tooltip you are unable to click or hover the tooltip content, in Popover you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants