Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable scrolling in modals (fixes #23) #27

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

gushogg-blake
Copy link
Contributor

This also fixes clicking the sides of the modal to close.

@vercel
Copy link

vercel bot commented Apr 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

flowbite-svelte – ./

🔍 Inspect: https://vercel.com/okadashinichi/flowbite-svelte/HjTb9wrZNo9Zk5Yaf46bLzik8dpE
✅ Preview: https://flowbite-svelte-git-fork-gushogg-blake-main-okadashinichi.vercel.app

flowbite-svelte-test – ./

🔍 Inspect: https://vercel.com/okadashinichi/flowbite-svelte-test/DnJo1Ji15dcH9VYwYK97EydSnxwo
✅ Preview: https://flowbite-svelte-test-git-fork-gushogg-blake-main-okadashinichi.vercel.app

@shinokada
Copy link
Collaborator

shinokada commented Apr 11, 2022

Since your branch is behind the upstream master, I have difficulties to merge the request. Can you fetch the latest version of the branch:

git checkout your-branch
git pull upstream master

Or

git checkout your-branch
git pull --rebase upstream master

Please let me know.

@gushogg-blake
Copy link
Contributor Author

I've merged latest main now, does that work?

@shinokada shinokada merged commit 809d27f into themesberg:main Apr 11, 2022
@shinokada
Copy link
Collaborator

Yep. it worked. I merged it and updated npm to 0.13.3. Thanks again for your great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants