Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dropdown new version #310

Merged
merged 3 commits into from
Sep 22, 2022
Merged

feat: dropdown new version #310

merged 3 commits into from
Sep 22, 2022

Conversation

jjagielka
Copy link
Contributor

πŸ“‘ Description

Dropdowns re-written:

  • introduced the concept of header and footer slots
  • changed to use rounded instead of rounded-lg - this is a major inconsistency from Flowbite.com
  • DropdownItems implement as active element <a/> or <button/> to allow catching events
  • custom dropdown items achieved by using <li/> directly

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

API changes introduced.

@vercel
Copy link

vercel bot commented Sep 21, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
flowbite-svelte βœ… Ready (Inspect) Visit Preview Sep 22, 2022 at 9:05AM (UTC)
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview Sep 22, 2022 at 9:05AM (UTC)

@shinokada
Copy link
Collaborator

Dropdown navbar in a mobile size

Before opening:
image

After opening:
image

In the before opening, the logo and the hamburger menu is too close. When you open the menu, the logo position changes.

@jjagielka
Copy link
Contributor Author

This in not a drop-down bug. It's the implementation of navbar.

@shinokada
Copy link
Collaborator

From #23 of validator

Error: Attribute href not allowed on element div at this point.

From line 414, column 5; to line 414, column 297

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants