Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make <TableHead> slot more flexible #527

Merged
merged 3 commits into from
Jan 14, 2023

Conversation

RyanZhiNie
Copy link
Contributor

@RyanZhiNie RyanZhiNie commented Jan 12, 2023

πŸ“‘ Description

The current <TableHead> component just put the slot in a <tr> element. This weakens the flexibility of this component, such as multiple head rows or style modification on head rows. For the sake of compatibility with users' existing code, I add a boolean prop defaultRow rather than deleting that single <tr> element.

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

@vercel
Copy link

vercel bot commented Jan 12, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add your feedback Jan 14, 2023 at 6:41AM (UTC)
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add your feedback Jan 14, 2023 at 6:41AM (UTC)

@shinokada
Copy link
Collaborator

shinokada commented Jan 12, 2023

Thank you for your PR.
Can you run tests by npm run test?
Can you also confirm this is based on the latest commit.
Once they are done, please check in the boxes.

@RyanZhiNie
Copy link
Contributor Author

RyanZhiNie commented Jan 13, 2023

I have updated my PR to let it be based on the latest commit, but unluckily I cannot successfully start up the tests with trying 10 times, it kept timeout. However, my local dev and the two previews deployed by the github vercel bot all don't show any bug, so this PR may be safe enough to be merged. It's okay to let this PR wait for a few days, I will try to run the tests more times.

image

@RyanZhiNie
Copy link
Contributor Author

After adjusting the playwright webServer.timeout configuration to 300000, I finally started up the tests, and except xxx page should have h1, there were no other failed tests. BTW, this PR is updated again to be based on the latest commit.

@shinokada shinokada merged commit 33803f2 into themesberg:main Jan 14, 2023
@RyanZhiNie RyanZhiNie deleted the change-tablehead-slot branch January 15, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants