Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TableBodyRow color and border #539

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

RyanZhiNie
Copy link
Contributor

πŸ“‘ Description

The current processing of <TableBodyRow>'s border stye is really weird. It changes the style of background color rather than border. And in fact, the prop trClass is presently used to set the styles when there are borders, and the value of this prop is also a background color style, which is also very weird. What's more, these problems cause the appearance of examples different from those displayed in Flowbite.

E.g., Flowbite (there are borders between every two <tr>s):
image

Flowbite-Svelte (the borders are missing):
image

BTW, I export color in my PR because I think there may be a situation when users want to set colors for different <tr> in a table.

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

@vercel
Copy link

vercel bot commented Jan 17, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add your feedback Jan 17, 2023 at 3:32PM (UTC)
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add your feedback Jan 17, 2023 at 3:32PM (UTC)

@shinokada
Copy link
Collaborator

Thank you for your PR.

@RyanZhiNie RyanZhiNie deleted the fix-TableBodyRow branch January 18, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants