fix: TableBodyRow color and border #539
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Description
The current processing of
<TableBodyRow>
's border stye is really weird. It changes the style of background color rather than border. And in fact, the proptrClass
is presently used to set the styles when there are borders, and the value of this prop is also a background color style, which is also very weird. What's more, these problems cause the appearance of examples different from those displayed in Flowbite.E.g., Flowbite (there are borders between every two
<tr>
s):Flowbite-Svelte (the borders are missing):
BTW, I export
color
in my PR because I think there may be a situation when users want to set colors for different<tr>
in a table.β Checks