Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run playwright on ci #566

Merged
merged 5 commits into from
Feb 17, 2023
Merged

Conversation

christophsturm
Copy link
Contributor

this pr runs playwright on github ci.

it could also run lint and sveltekit check, but those currently report failures.

@vercel
Copy link

vercel bot commented Feb 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
flowbite-svelte ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 9:22AM (UTC)
flowbite-svelte-update ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 9:22AM (UTC)

@shinokada
Copy link
Collaborator

shinokada commented Feb 8, 2023

Error on Run Playwright tests.

image

@shinokada
Copy link
Collaborator

Error.

image

@christophsturm
Copy link
Contributor Author

yes, I don't know why it fails, it works locally and on other projects where I use that workflow.

@shinokada
Copy link
Collaborator

Can you resolve the conflicting files?
Some of the packages are new but some are old.

@shinokada
Copy link
Collaborator

shinokada commented Mar 3, 2023

@christophsturm Can you check what's wrong with this, please?
All the tests pass locally, but when I create a PR, it fails.
Is it because of the new package versions?

  1) components.spec.ts:4:1 › Accordion page should have h1 ────────────────────────────────────────

    browserType.launch: Executable doesn't exist at /ms-playwright/chromium-1048/chrome-linux/chrome
    ╔══════════════════════════════════════════════════════════════════════╗
    ║ Looks like Playwright Test or Playwright was just updated to 1.31.2. ║
    ║ Please update docker image as well.                                  ║
    ║ -  current: mcr.microsoft.com/playwright:v1.30.0-focal               ║
    ║ - required: mcr.microsoft.com/playwright:v1.31.2-focal               ║
    ║                                                                      ║
    ║ <3 Playwright Team       

@shinokada
Copy link
Collaborator

@christophsturm Don't worry. I think I know how to fix it.

@christophsturm
Copy link
Contributor Author

Just need to bump the docker image version in the workflow

@shinokada
Copy link
Collaborator

shinokada commented Sep 22, 2023

@christophsturm I'm getting errors and not able to solve it. Can you have a look at it?

I have no problem running tests on localhost.

https://github.com/themesberg/flowbite-svelte/actions

image

@shinokada
Copy link
Collaborator

@christophsturm Never mind. It started working again on GitHub. It is very strange. Thanks anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants