Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery #643

Merged
merged 4 commits into from
Apr 5, 2023
Merged

Gallery #643

merged 4 commits into from
Apr 5, 2023

Conversation

jjagielka
Copy link
Contributor

πŸ“‘ Description

Further tweaking the Gallery component:

  • removal of GalleryItem - after all it's not needed
  • new examples of specific customizations

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

@stackblitz
Copy link

stackblitz bot commented Apr 5, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Apr 5, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 5, 2023 1:32pm
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 5, 2023 1:32pm

@jjagielka
Copy link
Contributor Author

@shinokada - I can't see why it failed

@shinokada
Copy link
Collaborator

shinokada commented Apr 5, 2023

@jjagielka It is because you removed a component and it is still in the package.json.

Try this. It will update the modular exports in the package.json.

npm run add-exports

Then run the test locally.

npm run test

@jjagielka
Copy link
Contributor Author

jjagielka commented Apr 5, 2023

It is because you removed a component and it is still in the package.json.

Yes, that was it. Thanks.

@jjagielka
Copy link
Contributor Author

And by the way: the file src/lib/types.js, it is pure typescript file, shouldn't it be suffixed with .ts? VS Code shows errors.

@shinokada
Copy link
Collaborator

shinokada commented Apr 5, 2023

Yes, you are right. It should be types.ts.
But I think I had a problem when I try to build it.
I will check it.

@shinokada shinokada merged commit 4f409fd into themesberg:main Apr 5, 2023
2 checks passed
@jjagielka jjagielka deleted the gallery branch April 5, 2023 20:43
@jjagielka jjagielka restored the gallery branch April 5, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants