Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figma #657

Merged
merged 123 commits into from
Apr 20, 2023
Merged

Figma #657

merged 123 commits into from
Apr 20, 2023

Conversation

jjagielka
Copy link
Contributor

@jjagielka jjagielka commented Apr 13, 2023

πŸ“‘ Description

The first draft of the new design.

  • High level navigation adjusted but needs rethinking
  • Landing page not touched yet
  • Components pages - full focus was there so far

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

@stackblitz
Copy link

stackblitz bot commented Apr 13, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Apr 13, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 20, 2023 10:03am
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 20, 2023 10:03am

@shinokada
Copy link
Collaborator

Let me know when you want me to merge.

@jjagielka
Copy link
Contributor Author

This is probably wider team decision. Please play with it and make your opinion what's the minimal state of changes we are OK to show to the world.

@zoltanszogyenyi
Copy link
Member

I think that we're almost ready to merge.

One more thing I would take care of - when you open the navigation menu on mobile devices and go to another page the menu stays open and I believe we should close it as a default behaviour.

Screen.Recording.2023-04-20.at.12.22.45.mov

Copy link
Member

@zoltanszogyenyi zoltanszogyenyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge it!

The other tasks can be broken up into multiple issues and PRs.

@shinokada you do the honors.

Good job peeps! @jjagielka

@jjagielka
Copy link
Contributor Author

Wait a minute.

@jjagielka
Copy link
Contributor Author

when you open the navigation menu on mobile devices ...

Done.

@zoltanszogyenyi
Copy link
Member

Awesome! We're ready to merge @shinokada.

@shinokada
Copy link
Collaborator

Give me 10 min.

@shinokada shinokada merged commit f338e23 into themesberg:main Apr 20, 2023
2 checks passed
@shinokada
Copy link
Collaborator

Merged.
Thank you all. Great work!

@jjagielka jjagielka deleted the figma branch April 21, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants