Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: more alert options #67

Merged
merged 4 commits into from
May 11, 2022
Merged

feat: more alert options #67

merged 4 commits into from
May 11, 2022

Conversation

edde746
Copy link
Contributor

@edde746 edde746 commented May 10, 2022

No description provided.

@vercel
Copy link

vercel bot commented May 10, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
flowbite-svelte ✅ Ready (Inspect) Visit Preview May 11, 2022 at 9:44AM (UTC)

@shinokada
Copy link
Collaborator

Thanks for the PR. I will have a look.

@shinokada
Copy link
Collaborator

shinokada commented May 10, 2022 •
edited
Loading

  • Additional content dismiss is removed. Can you add it?
  • Since all paragraph in the dark mode is black, I will put it back the CSS.
    image
  • Thank you for refactoring all the CSS.
  • Test fails.

image

@edde746
Copy link
Contributor Author

edde746 commented May 11, 2022

Fixed all the issues mentioned.

@shinokada shinokada merged commit fa46244 into themesberg:main May 11, 2022
@shinokada
Copy link
Collaborator

Thanks. I merged it.

  • Due to A11y I put back CSS and added more CSS.
  • I changed dismiss to Go to Home.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edde746 @shinokada