Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: newsletter form #674

Merged
merged 5 commits into from
Apr 22, 2023
Merged

feat: newsletter form #674

merged 5 commits into from
Apr 22, 2023

Conversation

jjagielka
Copy link
Contributor

@jjagielka jjagielka commented Apr 20, 2023

  • Not completed
  • Completed

Closes #667

πŸ“‘ Description

Newsletter section.

TODO: subscription command

  • send by 'on:click'
  • or send as a form action?
  • what is the address the e-mail should be sent to?

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

@stackblitz
Copy link

stackblitz bot commented Apr 20, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 22, 2023 7:37am
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 22, 2023 7:37am

@jjagielka
Copy link
Contributor Author

@zoltanszogyenyi where should the user's email be sent to?
I found that: action="https://app.convertkit.com/forms/4692392/subscriptions" in Flowbite.com. Should I copy paste the data from there or flowbite-svelte would have another parameters?

@zoltanszogyenyi
Copy link
Member

Hey @jjagielka,

Yeah that should be okay - I'll test it out later if it gets added to our ConvertKit account.

I think we'll need to add a tag for svelte at some point so we can better target them.

@shinokada
Copy link
Collaborator

FYI: error messages

image

@shinokada
Copy link
Collaborator

Now it is working. Is this PR completed?

image

@jjagielka
Copy link
Contributor Author

Yes, it is.

@shinokada shinokada merged commit 89df011 into themesberg:main Apr 22, 2023
2 checks passed
@jjagielka jjagielka deleted the newsletter branch April 23, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add newsletter section at the end of each doc page
3 participants