Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/doc search #676

Merged
merged 11 commits into from
Apr 24, 2023
Merged

Feature/doc search #676

merged 11 commits into from
Apr 24, 2023

Conversation

zoltanszogyenyi
Copy link
Member

@zoltanszogyenyi zoltanszogyenyi commented Apr 21, 2023

Closes #665

πŸ“‘ Description

This PR adds the Algolia search functionality to the website.

  • [] Not Completed
  • Completed

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

@stackblitz
Copy link

stackblitz bot commented Apr 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Apr 21, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 24, 2023 1:58pm
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 24, 2023 1:58pm

@zoltanszogyenyi
Copy link
Member Author

Let's not merge this just yet - there's some weird JS error when coming from the homepage.

@zoltanszogyenyi
Copy link
Member Author

Okay, now this should be good to go. Can you please check @shinokada @jjagielka?

@shinokada
Copy link
Collaborator

shinokada commented Apr 21, 2023

  • No resutls are shown with any components, modal, alert, button, etc.

image

image

@zoltanszogyenyi
Copy link
Member Author

Hey @shinokada,

I'll have to create a crawling action on the Algolia dashboard and it's decoupled from the front-end functionality.

We should also merge the broken links PR because that's preventing Algolia from properly crawling the website.

I'll make sure all pages are crawled by the end of today.

@shinokada
Copy link
Collaborator

shinokada commented Apr 21, 2023

@zoltanszogyenyi Ok, thanks. #678 is merged

@zoltanszogyenyi
Copy link
Member Author

I reached out to the peeps from Algolia to debug the crawling - there's some weird bug even if the config is okay.

Also we'll need to add canonical links to all pages - I'm working on a PR right now and I'll also add some tests.

For example, a page like https://flowbite-svelte.com/docs/components/accordion should have a canonical link tag:

<link rel="canonical" href="https://flowbite-svelte.com/docs/components/accordion" />

Luckily, the MetaTags component from Svelte has this attribute so it won't be that hard to integrate.

@zoltanszogyenyi
Copy link
Member Author

Hey @shinokada,

All pages are now crawled - I also merged with main locally and everything should work.

If you can test it then we can merge it.

Cheers,
Zoltan

@shinokada
Copy link
Collaborator

@zoltanszogyenyi How often does Algolia crawl the website?

@shinokada
Copy link
Collaborator

The search can't find the Range nor Slider.
image

image

We have the Range component page.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Algolia Search
2 participants