Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figma design element for home page #684

Merged
merged 2 commits into from
Apr 22, 2023
Merged

Conversation

jjagielka
Copy link
Contributor

πŸ“‘ Description

figma design element for home page

  • Not Completed
  • Completed

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

@stackblitz
Copy link

stackblitz bot commented Apr 22, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Apr 22, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 22, 2023 8:53pm
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 22, 2023 8:53pm

@shinokada
Copy link
Collaborator

There are no links are added. Where should we direct to?

image

@shinokada
Copy link
Collaborator

shinokada commented Apr 22, 2023

@zoltanszogyenyi I think the link for Preview in Figma is https://www.figma.com/file/5pHMkriSz9q98zawojb4mx/flowbite-pro-figma-v2.5.0?node-id=18-0&t=X431WUvSP7jsPiEI-0, and the link for Duplicate Flowbite Design System is https://flowbite.com/figma/. But the title should be "Learn more" or "Figma design system".

I will update these for now and we can change them later.

@jjagielka jjagielka deleted the design_figma branch April 23, 2023 07:32
@shinokada
Copy link
Collaborator

shinokada commented Apr 23, 2023

On iPad, I get this.
I think we should hide the image for iPad width or make the image smaller or responsive.

72135

And this happens with 1040 px on my laptop as well.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants