Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: home page cta #689

Merged
merged 12 commits into from
Apr 28, 2023
Merged

feat: home page cta #689

merged 12 commits into from
Apr 28, 2023

Conversation

jjagielka
Copy link
Contributor

@jjagielka jjagielka commented Apr 23, 2023

πŸ“‘ Description

CTA element for the Home Page

Status

  • Not Completed
  • Completed

Content is copied directly from Figma but it looks like a temporary one.

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

@stackblitz
Copy link

stackblitz bot commented Apr 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Apr 23, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 27, 2023 2:10pm
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 27, 2023 2:10pm

@zoltanszogyenyi
Copy link
Member

Hey @jjagielka,

I've updated some spacings and the content.

It would be cool to make the dark / light mode switcher <button> and make them interactive - meaning they should toggle dark and light mode just like the button does in the navbar.

After that I'll check it out once again and I think it'll be good to merge.

Great job!

Cheers,
Zoltan

@jjagielka
Copy link
Contributor Author

@zoltanszogyenyi - done, please check.

@zoltanszogyenyi
Copy link
Member

Hey @jjagielka,

Works great! Just one more thing - it would be nice if the dark mode button (with the moon) will become active (ie. orange/primary color) and the light mode becomes inactive when switching over and back and forth.

For example when dark mode is active then the moon button should be orange and the light button gray and same thing applies for when light mode is active.

Screenshot 2023-04-27 at 15 34 53

Then I think we can merge it for sure.

Cheers,
Zoltan

@jjagielka
Copy link
Contributor Author

I've made it the other way. When the dark is selected, the light button is orange to attract clicking. In light mode, dark button gets the look. I can swap it back if you disagree with that.

@zoltanszogyenyi
Copy link
Member

Hey @jjagielka,

Thanks for the update - yeah I think we should reverse it.

Light mode active: sun button orange, moon button grey
Dark mode active: moon button orange, sub button grey

And one more thing -> only the gray button should be clickable because that's the one you can switch to, clicking the same theme mode has no sense because it shouldn't change anything. For example, I'm in dark mode, there's no need to click on dark mode again.

Hope it makes sense!

@shinokada
Copy link
Collaborator

Please update the status when it is ready for merge.

image

@zoltanszogyenyi
Copy link
Member

Hey @jjagielka @shinokada,

Works great - it's ready to be merged <3

Cheers,
Zoltan

@shinokada shinokada merged commit 76d7eb5 into themesberg:main Apr 28, 2023
4 checks passed
@jjagielka jjagielka deleted the cta branch April 28, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants