-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: home page cta #689
feat: home page cta #689
Conversation
Run & review this pull request in StackBlitz Codeflow. |
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Hey @jjagielka, I've updated some spacings and the content. It would be cool to make the dark / light mode switcher After that I'll check it out once again and I think it'll be good to merge. Great job! Cheers, |
@zoltanszogyenyi - done, please check. |
Hey @jjagielka, Works great! Just one more thing - it would be nice if the dark mode button (with the moon) will become active (ie. orange/primary color) and the light mode becomes inactive when switching over and back and forth. For example when dark mode is active then the moon button should be orange and the light button gray and same thing applies for when light mode is active. Then I think we can merge it for sure. Cheers, |
I've made it the other way. When the dark is selected, the light button is orange to attract clicking. In light mode, dark button gets the look. I can swap it back if you disagree with that. |
Hey @jjagielka, Thanks for the update - yeah I think we should reverse it. Light mode active: sun button orange, moon button grey And one more thing -> only the gray button should be clickable because that's the one you can switch to, clicking the same theme mode has no sense because it shouldn't change anything. For example, I'm in dark mode, there's no need to click on dark mode again. Hope it makes sense! |
Hey @jjagielka @shinokada, Works great - it's ready to be merged <3 Cheers, |
π Description
CTA element for the Home Page
Status
Content is copied directly from Figma but it looks like a temporary one.
β Checks
βΉ Additional Information