Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initial refresh fix #693

Merged
merged 3 commits into from
Apr 24, 2023
Merged

fix: initial refresh fix #693

merged 3 commits into from
Apr 24, 2023

Conversation

jjagielka
Copy link
Contributor

@jjagielka jjagielka commented Apr 24, 2023

πŸ“‘ Description

Fixes the ExampleWrapper. Initial refresh issue prevented from displaying Edit on GitHub buttons.

  • Not Completed
  • Completed

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

@stackblitz
Copy link

stackblitz bot commented Apr 24, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Apr 24, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 24, 2023 9:34pm
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 24, 2023 9:34pm

@shinokada
Copy link
Collaborator

shinokada commented Apr 24, 2023

Where there are more than two words, it replaces a space with an underbar.

image

The link goes to https://github.com/themesberg/flowbite-svelte/blob/main/src/routes/docs/components/bottom-navigation.md#application-bar_example. The last _example should be -example.

The same to other links, e.g. https://github.com/themesberg/flowbite-svelte/blob/main/src/routes/docs/components/bottom-navigation.md#example-with_pagination

@shinokada
Copy link
Collaborator

It seems like it's ready to be merged. Let me know.

@jjagielka
Copy link
Contributor Author

Yes go on. Thanks for catching the issues.

@shinokada shinokada merged commit 7479934 into themesberg:main Apr 24, 2023
2 checks passed
@jjagielka jjagielka deleted the fix-git-hub branch April 24, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants