-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add mouse and touch swipe gesture to the Carousel component. #719
Conversation
Run & review this pull request in StackBlitz Codeflow. |
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
The unl.edu validator on https://flowbite-svelte-rho.vercel.app/docs/components/carousel produces a bunch of errors, but I do not believe I have introduced any new errors. |
β¦.log() message.
@minervabot Is this complete? Can you fix the conflicts? |
@shinokada I think that it works reasonably well, but I have not given it much attention for a while. Are you interested in using a third-party library? This one works very well in React and regular JS, and now supplies a Svelte integration as well. It is not as popular, but it is only a binding for the JS library which is much more popular. I would be happy to make a different PR integrating it! |
We'd like to avoid increasing the number of peerDependencies as much as possible. |
Closes #
π Description
This implements basic swipe gestures to change slides on the Carousel component. I think it is ready to use as is, but further PRs might include code to ignore more vertical touch gestures to not interfere with scrolling, and integrating the swiping movement with the transition animations.
Status
β Checks
βΉ Additional Information