Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add mouse and touch swipe gesture to the Carousel component. #719

Merged
merged 5 commits into from
Aug 23, 2023

Conversation

minervabot
Copy link
Contributor

@minervabot minervabot commented May 3, 2023

Closes #

πŸ“‘ Description

This implements basic swipe gestures to change slides on the Carousel component. I think it is ready to use as is, but further PRs might include code to ignore more vertical touch gestures to not interfere with scrolling, and integrating the swiping movement with the transition animations.

Status

  • Not Completed
  • Completed

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

@stackblitz
Copy link

stackblitz bot commented May 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented May 3, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte ❌ Failed (Inspect) Aug 22, 2023 7:16pm
flowbite-svelte-update ❌ Failed (Inspect) Aug 22, 2023 7:16pm

@minervabot
Copy link
Contributor Author

The unl.edu validator on https://flowbite-svelte-rho.vercel.app/docs/components/carousel produces a bunch of errors, but I do not believe I have introduced any new errors.

@minervabot minervabot changed the title Add mouse and touch swipe gesture to the Carousel component. feat: Add mouse and touch swipe gesture to the Carousel component. May 3, 2023
@shinokada
Copy link
Collaborator

@minervabot Is this complete? Can you fix the conflicts?

@minervabot
Copy link
Contributor Author

@shinokada I think that it works reasonably well, but I have not given it much attention for a while. Are you interested in using a third-party library? This one works very well in React and regular JS, and now supplies a Svelte integration as well. It is not as popular, but it is only a binding for the JS library which is much more popular. I would be happy to make a different PR integrating it!

https://www.npmjs.com/package/embla-carousel-svelte

@shinokada
Copy link
Collaborator

We'd like to avoid increasing the number of peerDependencies as much as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants