Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Types updates #726

Merged
merged 3 commits into from
May 4, 2023
Merged

fix: Types updates #726

merged 3 commits into from
May 4, 2023

Conversation

shinokada
Copy link
Collaborator

@shinokada shinokada commented May 4, 2023

Closes #722

πŸ“‘ Description

  • Changed index.js and types.js to ts
  • Clean up types.ts

Status

  • Not Completed
  • Completed

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

@stackblitz
Copy link

stackblitz bot commented May 4, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented May 4, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 4, 2023 9:43pm
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 4, 2023 9:43pm

@shinokada shinokada merged commit 5a182b4 into themesberg:main May 4, 2023
4 checks passed
@shinokada shinokada deleted the type-fix branch May 4, 2023 21:44
@shinokada shinokada changed the title Type fix fix: Types updates May 4, 2023
jjagielka pushed a commit to jjagielka/flowbite-svelte that referenced this pull request May 5, 2023
* fix: remove un-used types

* fix: change js to ts file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Card size prop missing Type
1 participant