Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: typescript types for frame subclasses #731

Merged
merged 2 commits into from
May 5, 2023

Conversation

jjagielka
Copy link
Contributor

πŸ“‘ Description

Adds typescript support to components that are Frame subclasses

  • Frame props extended to: <a/>, class
  • components inherit props from Frame and add their own exports

Status

  • Not Completed
  • Completed

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

@stackblitz
Copy link

stackblitz bot commented May 5, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented May 5, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 5, 2023 7:36pm
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 5, 2023 7:36pm

@jjagielka
Copy link
Contributor Author

@shinokada this time it should work OK. :)

@shinokada
Copy link
Collaborator

What do you think about this issue that relating to the Frame component?

@jjagielka
Copy link
Contributor Author

jjagielka commented May 5, 2023

It's parent-child rounding issue. If parent is rounded-xl, then child should be rounded-xl as well or only rounded-lg?
Need to review the flowbite.com examples to find if we have a bug here.

@shinokada shinokada merged commit 6dd9877 into themesberg:main May 5, 2023
4 checks passed
@jjagielka jjagielka deleted the frame-types branch May 6, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants