Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typescript declarations for import.meta.glob #736

Merged
merged 1 commit into from
May 6, 2023

Conversation

jjagielka
Copy link
Contributor

πŸ“‘ Description

Typescript declaration for the import of markdown files in index.ts file.

Status

  • Not Completed
  • Completed

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

@stackblitz
Copy link

stackblitz bot commented May 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented May 6, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 6, 2023 0:15am
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 6, 2023 0:15am

@shinokada
Copy link
Collaborator

shinokada commented May 6, 2023

What are you trying to solve with this PR?
Do you have any type errors?

@jjagielka
Copy link
Contributor Author

npm run check

@shinokada
Copy link
Collaborator

There are 32 errors. Which one, may I ask?

@jjagielka
Copy link
Contributor Author

All of those:

Error: Property 'metadata' does not exist on type 'unknown'. 
    iterableExampleFiles.map(async ([path, resolver]) => {
      const { metadata } = await resolver();
      return {

@shinokada shinokada merged commit ef10a06 into themesberg:main May 6, 2023
4 checks passed
@jjagielka jjagielka deleted the glob-ts branch May 6, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants