-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update toast styles to fit latest official styles #763
Conversation
Run & review this pull request in StackBlitz Codeflow. |
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
@jjagielka Are you happy with this PR? |
Not at all. This PR introduce the new colors: However, I must admit that something went wrong with |
My understanding of Colors of the Toast component in Flowbite is not just for colors but for practical meaning, they are used to make the toasts somewhat like alerts. That's the reason why I remove the What's more, the |
@RyanZhiNie Thank you for your PR and contribution. The following is the comparison of two versions. Current Version:
PR Version:
|
I have updated this PR to reintroduce the |
I still don't get why to introduce |
Remove the |
colorPalette should have none with ''. |
Done. |
I have just two comments left for that PR:
|
π Description
Update the styles of the toast component to fit the latest official styles
Status
β Checks
βΉ Additional Information