Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accordion optional props #769

Merged
merged 1 commit into from
May 16, 2023
Merged

accordion optional props #769

merged 1 commit into from
May 16, 2023

Conversation

KiraPC
Copy link
Contributor

@KiraPC KiraPC commented May 16, 2023

Closes #768

πŸ“‘ Description

Since all the Accordion props have default values them should be optional in type descryptor.

Status

  • [] Not Completed
  • Completed

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

@stackblitz
Copy link

stackblitz bot commented May 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented May 16, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 16, 2023 1:46pm
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 16, 2023 1:46pm

@jjagielka
Copy link
Contributor

Completely agree. PR good to go.

@shinokada shinokada merged commit 6018a4b into themesberg:main May 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordion Type Issue
3 participants