Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align spinner style with flowbite docs. #82

Merged
merged 1 commit into from
May 30, 2022

Conversation

Codex-
Copy link
Contributor

@Codex- Codex- commented May 30, 2022

Closes #

πŸ“‘ Description

I went to use a spinner from this lib and noticed it looked a little odd, found that two values were back to front, nothing dramatic :)

Before change: https://flowbite-svelte.com/spinners
image

Expected based on: https://flowbite.com/docs/components/spinner/
image

After change:
image

You can preview the change with: pnpm run dev

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@vercel
Copy link

vercel bot commented May 30, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
flowbite-svelte βœ… Ready (Inspect) Visit Preview May 30, 2022 at 6:37AM (UTC)
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview May 30, 2022 at 6:37AM (UTC)

@shinokada
Copy link
Collaborator

shinokada commented May 30, 2022

Thank you for the PR. I just merged it.

@Codex- Codex- deleted the fix_spinner_style branch May 30, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants