Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update component colors to primary #820

Merged
merged 38 commits into from
Jun 5, 2023
Merged

Update component colors to primary #820

merged 38 commits into from
Jun 5, 2023

Conversation

zoltanszogyenyi
Copy link
Member

@zoltanszogyenyi zoltanszogyenyi commented Jun 2, 2023

📑 Description

This PR fixes the remaining rogue blue colors to primary and also improves the documentation by fixing certain spacings, invalid heading/links in the docs and also updates the config file for the bg-primary-50 color from blue to orange.

Status

  • Completed

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

@stackblitz
Copy link

stackblitz bot commented Jun 2, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@zoltanszogyenyi zoltanszogyenyi self-assigned this Jun 2, 2023
@vercel
Copy link

vercel bot commented Jun 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 10:44am
flowbite-svelte-update ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 10:44am

@shinokada
Copy link
Collaborator

@zoltanszogyenyi What do you think about this proposal?

@zoltanszogyenyi
Copy link
Member Author

Hey @shinokada,

This is ready to be reviewed.

@shinokada
Copy link
Collaborator

Since you updated exported variables, can you run pnpm gen:props and push it, please? It will update all the props and format them.

@zoltanszogyenyi
Copy link
Member Author

Since you updated exported variables, can you run pnpm gen:props and push it, please? It will update all the props and format them.

Running the command gives me the following error:

Screenshot 2023-06-04 at 19 04 19

@shinokada
Copy link
Collaborator

shinokada commented Jun 4, 2023

@zoltanszogyenyi Can you install all dependencies again?

pnpm i

@zoltanszogyenyi
Copy link
Member Author

@zoltanszogyenyi Can you install all dependencies again?

pnpm i

That worked, thanks! You can review the PR now. Also updated the primary colors based on @robert1508's updates on Figma @jjagielka.

Copy link
Collaborator

@shinokada shinokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@shinokada shinokada merged commit 2c9c5bf into main Jun 5, 2023
4 checks passed
@shinokada shinokada deleted the component-colors branch June 5, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants