-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Svelte 4 updates (Part 2) #825
Conversation
β¦ight, ChevronUp, InformationCirlc, and UserCircle components
β¦ button This makes the img element interactive.
Run & review this pull request in StackBlitz Codeflow. |
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
src/lib/buttons/Button.svelte
Outdated
@@ -126,7 +127,9 @@ | |||
on:keydown | |||
on:keyup | |||
on:mouseenter | |||
on:mouseleave> | |||
on:mouseleave | |||
role={href ? undefined : "button"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it is <button>
do you need role="button"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, you don't need it if the type is a button.
I will remove that line.
Since Frame is used in different components, the role will be different depending on the tag. |
Closes #813
π Description
Status
β Checks
βΉ Additional Information