Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte 4 updates (Part 2) #825

Merged
merged 20 commits into from
Jun 3, 2023
Merged

Svelte 4 updates (Part 2) #825

merged 20 commits into from
Jun 3, 2023

Conversation

shinokada
Copy link
Collaborator

@shinokada shinokada commented Jun 3, 2023

Closes #813

πŸ“‘ Description

  • buttons/Button.svelte:81:0 A11y: svelte:element with click, keydown, keyup, mouseenter, mouseleave handlers must have an ARIA role
  • dropdowns/DropdownItem.svelte:14:2 A11y: svelte:element with click, keydown, keyup, mouseenter, mouseleave handlers must have an ARIA role
  • forms/Dropzone.svelte:14:0 A11y: Non-interactive element should not be assigned mouse or keyboard event listeners.
  • modals/Modal.svelte:126:8 A11y:
    with keydown handler must have an ARIA role
  • modals/Modal.svelte:91:2 A11y: Non-interactive element
    should not be assigned mouse or keyboard event listeners.
  • navbar/NavLi.svelte:13:2 A11y: svelte:element with click, keydown, keypress, keyup, mouseenter, mouseleave, mouseover handlers must have an ARIA role
  • navbar/NavUl.svelte:25:2 A11y:
    with click handler must have an ARIA role
  • paginations/PaginationItem.svelte:13:0 A11y: svelte:element with click, keydown, keypress, keyup, mouseenter, mouseleave, mouseover handlers must have an ARIA role
  • ratings/Star.svelte:10:0 A11y: with click handler must have an ARIA role
  • ratings/Thumbup.svelte:9:0 A11y: with click handler must have an ARIA role
  • ratings/Heart.svelte:9:0 A11y: with click handler must have an ARIA role
  • tables/TableBodyCell.svelte:12:0 A11y: Non-interactive element should not be assigned mouse or keyboard event listeners.
  • utils/ChevronDown.svelte:24:0 A11y: with click handler must have an ARIA role
  • utils/ChevronLeft.svelte:24:0 A11y: with click handler must have an ARIA role
  • utils/ChevronRight.svelte:24:0 A11y: with click handler must have an ARIA role
  • utils/ChevronUp.svelte:24:0 A11y: with click handler must have an ARIA role
  • utils/InformationCircle.svelte:24:0 A11y: with click handler must have an ARIA role
  • utils/UserCircle.svelte:24:0 A11y: with click handler must have an ARIA role
  • utils/Frame.svelte:84:2 A11y: svelte:element with click, mouseenter, mouseleave handlers must have an ARIA role
  • utils/Frame.svelte:99:2 A11y: svelte:element with click, mouseenter, mouseleave handlers must have an ARIA role
  • navbar/Menu.svelte:24:0 A11y: with click handler must have an ARIA role
  • carousels/Thumbnail.svelte:10:0 A11y: Non-interactive element should not be assigned mouse or keyboard event listeners.

Status

  • Not Completed
  • Completed

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

@stackblitz
Copy link

stackblitz bot commented Jun 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Jun 3, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 3, 2023 10:18pm
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 3, 2023 10:18pm

@@ -126,7 +127,9 @@
on:keydown
on:keyup
on:mouseenter
on:mouseleave>
on:mouseleave
role={href ? undefined : "button"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it is <button> do you need role="button"

Copy link
Collaborator Author

@shinokada shinokada Jun 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you don't need it if the type is a button.
I will remove that line.

@shinokada
Copy link
Collaborator Author

Since Frame is used in different components, the role will be different depending on the tag.
I just leave it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sveltejs@4.0.0-next.0 Pre-release check
2 participants