Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Component: MultiSelect #841

Merged
merged 8 commits into from
Jun 9, 2023
Merged

Conversation

vasucp1207
Copy link
Contributor

@vasucp1207 vasucp1207 commented Jun 7, 2023

Closes #

πŸ“‘ Description

An initial version of multi-select component #50.

multi-select

Status

  • Not Completed
  • Completed

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

@stackblitz
Copy link

stackblitz bot commented Jun 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Jun 7, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 9, 2023 0:56am
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 9, 2023 0:56am

@vasucp1207
Copy link
Contributor Author

@shinokada, what are your thoughts on this?

@shinokada
Copy link
Collaborator

Thank you for your PR. It looks good.
Can you put your example after Select input example rather than having a separate page? I think it is a better place for users.

@vasucp1207
Copy link
Contributor Author

Thank you for your PR. It looks good. Can you put your example after Select input example rather than having a separate page? I think it is a better place for users.

Made the necessary changes check now.

@shinokada shinokada merged commit 656f2ed into themesberg:main Jun 9, 2023
4 checks passed
@shinokada
Copy link
Collaborator

Thank you for adding this new component with its new features to the project.
Your contribution is greatly appreciated and will help improve the project.
Great work and keep it coming.

@shinokada
Copy link
Collaborator

shinokada commented Jun 10, 2023

Can you start using the Conventional commit when you write a commit comment?

Please use fix:, feat:, chore:, docs:, style:, refactor:, perf:, test:, etc.

@vasucp1207
Copy link
Contributor Author

Ok, I will take care of this from now.

@shinokada
Copy link
Collaborator

Since you are the author of Multi Select, please join this conversation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants