Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: svelte 4 #874

Merged
merged 15 commits into from
Jun 28, 2023
Merged

feat: svelte 4 #874

merged 15 commits into from
Jun 28, 2023

Conversation

ezegros
Copy link
Contributor

@ezegros ezegros commented Jun 24, 2023

Closes #873

📑 Description

Migrate to Svelte 4

  • Upgrade dependencies
  • MultiSelect.svelte:53:10 A11y: with click handler must have an ARIA role
  • MultiSelect.svelte:106:8 A11y:
    with click handler must have an ARIA role
  • MultiSelect.svelte:43:0 A11y:
    with click handler must have an ARIA role
  • Modal.svelte:127:8 A11y: Non-interactive element
    should not be assigned mouse or keyboard event listeners.
  • Modal.svelte:92:2 A11y: Non-interactive element
    should not be assigned mouse or keyboard event listeners.
  • PaginationItem.svelte:22:0 A11y: svelte:element with click, keydown, keypress, keyup, mouseenter, mouseleave, mouseover handlers must have an ARIA role.
  • Frame.svelte:87:2 A11y: svelte:element with click, mouseenter, mouseleave handlers must have an ARIA role.
  • Frame.svelte:102:2 A11y: svelte:element with click, mouseenter, mouseleave handlers must have an ARIA role.
  • Button.svelte:79:0 A11y: svelte:element with click, keydown, keyup, mouseenter, mouseleave handlers must have an ARIA role.
  • routes/docs/+layout.svelte:73:0 A11y:
    with click, keydown handlers must have an ARIA role
  • src/lib/navbar/SidebarMenu.svelte:24:0 A11y: with click handler must have an ARIA role

Status

  • Not Completed
  • Completed

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

ℹ Additional Information

@stackblitz
Copy link

stackblitz bot commented Jun 24, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Jun 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 1:13pm
flowbite-svelte-update ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 1:13pm

@shinokada
Copy link
Collaborator

@ezegrosfeld Is this completed?
@jjagielka Can you check for Frame, Wrapper, and Button?

@jjagielka
Copy link
Contributor

Two comments:

  • it's behind the main branch, so please be sure to catch up before merging
  • I don't think we need |global at transitions. Change to local by default was well thought by Svelte team. Can you please remove those?

@jjagielka
Copy link
Contributor

Looks OK for me. Thanks.

@shinokada
Copy link
Collaborator

shinokada commented Jun 26, 2023

@ezegrosfeld The status is not complete.
Let me know when it is ready to merge.

@ezegros
Copy link
Contributor Author

ezegros commented Jun 27, 2023

@shinokada Yes, sorry! I've just marked it as completed.

@iBuaSpaz
Copy link

As fairly new to github, when this update released so i can use this, im annoyed every time i open/build with all the tons of vite-plugin-svelte errors about Aria role :)

Do this automaticly update when this is pushed or do i have to get some beta some way to use latest code?

@shinokada shinokada merged commit 86ea2a9 into themesberg:main Jun 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to svelte@4.0.0
4 participants