Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add shrink-0 to prevent toggle UI from shrinking on small screen sizes #885

Merged
merged 1 commit into from
Jul 3, 2023
Merged

fix: add shrink-0 to prevent toggle UI from shrinking on small screen sizes #885

merged 1 commit into from
Jul 3, 2023

Conversation

darbymanning
Copy link
Contributor

@darbymanning darbymanning commented Jun 30, 2023

📑 Description

Currently on small device sizes the toggle shrinks and clips. This PR resolves this by adding shrink-0.

Video showing current issue

Toggle.issue.mov

Video showing result with shrink-0 applied

Toggle.shrink-0.mov

Status

  • Not Completed
  • Completed

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

@vercel
Copy link

vercel bot commented Jun 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2023 8:32pm
flowbite-svelte-update ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2023 8:32pm

@shinokada
Copy link
Collaborator

Can you show us your screenshot when the toggle button shrinks?

@darbymanning
Copy link
Contributor Author

Can you show us your screenshot when the toggle button shrinks?

Sure, updated the PR description.

@shinokada shinokada merged commit 81c65bd into themesberg:main Jul 3, 2023
4 checks passed
@darbymanning darbymanning deleted the fix-toggle-size-on-small-devices branch July 4, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants