fix: Clicking on dropzone component triggers onsubmit event on parent…

[anjaneyasivan]

Closes #

📑 Description

Status

• Not Completed
• Completed

✅ Checks

• My pull request adheres to the code style of this project
• My code requires changes to the documentation
• I have updated the documentation as required
• I have checked the page with https://validator.unl.edu/
• All the tests have passed
• My pull request is based on the latest commit (not the npm version).

ℹ Additional Information

---

Submitted with StackBlitz Codeflow.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
flowbite-svelte	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 7, 2023 7:01pm
flowbite-svelte-update	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 7, 2023 7:01pm

[shinokada]

Thank you for your PR.
Since the tag is button, you don't need to add type="button".

I close this PR but I'm looking forward to seeing your future PRs.
Thank you for your contribution.

[anjaneyasivan]

@shinokada, thanks for clarifying. I happened to notice that the Dropzone.svelte file contains an input tag inside a button tag. I was just wondering if this is considered semantically correct. Thank you for your time and help!

[fuzzie360]

Hi @shinokada, I'm affected by the issue referenced here #906 and this fixes my issue exactly.

I don't understand the reason behind the closure:

Since the tag is button, you don't need to add type="button"

The default attribute for the button tag for many browsers is "submit" not "button". This will cause the Dropzone to trigger a form submit if it is in a form.

Perhaps Dropzone should be more props so that we can control wether Dropzone will submit or not submit depending on the use case.

Wdyt?

[shinokada]

I reopened this and will merge it.
It will be in the next version.
Thank you for your PR.