fix(Input): Use a reactive spread instead of custom action to set Input type attribute
#921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Not-Jayden
changed the title
border class to Input defaultClasstype attribute
Not-Jayden
changed the title
type attributetype attribute
Not-Jayden
changed the title
type attributetype attribute
|
That's a neat trick. Let's use it. Please approve. |
|
Wouldn't this change make sense for FloatingLabelInput.svelte too? The same custom action is used there that was replaced here. |
|
Yes, it would. @Not-Jayden can you make the same change at |
8 tasks
Done :) #927 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
Adjust the way the type attribute is set to use a reactively spread object rather than a custom action to circumvent the svelte warning. The motivation for this change is that currently the border is dependent on a
typeattribute being set on the input, which gets its styling from the global Flowbite CSS file.This causes a brief flicker in the input's border given the attribute is being set with javascript after it first mounts, and just doesn't render a border at all if JS is disabled.
With the reactive spread, the input does have the type attribute already set on mount so the border will be present even without JS.
Status
✅ Checks
ℹ Additional Information
Also not sure if the border class should just be added in the defaultClass as well, but this is a less breaking change.