Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating UI #930

Merged
merged 5 commits into from
Jul 15, 2023
Merged

Floating UI #930

merged 5 commits into from
Jul 15, 2023

Conversation

jjagielka
Copy link
Contributor

@jjagielka jjagielka commented Jul 15, 2023

📑 Description

Re-implementation of Popper with @floating-ui.

  • change in package.json
    • removed @popperjs/core
    • added @floating-ui/dom
  • Popper component re-written
  • Few tweaks to Tooltip, MegaMenu

Status

  • Not Completed
  • Completed

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

ℹ Additional Information

@stackblitz
Copy link

stackblitz bot commented Jul 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Jul 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2023 9:52am
flowbite-svelte-update ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2023 9:52am

@shinokada
Copy link
Collaborator

shinokada commented Jul 15, 2023

Can you update the introduction and quickstart page as well?

@shinokada
Copy link
Collaborator

This will be a breaking change, so I will release version 0.40.

@jjagielka
Copy link
Contributor Author

What is a breaking change here? The API does not change for any component.

@shinokada
Copy link
Collaborator

shinokada commented Jul 15, 2023

You have to install a different dependency.

 -  "@popperjs/core": "^2.11.8",
 +  "@floating-ui/dom": "^1.4.5",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants