Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added events to BottomNavHeaderItem #941

Conversation

fkrauthan
Copy link
Contributor

Closes #938

📑 Description

Added missing event handler to BottomNavHeaderItem

Status

  • Not Completed
  • Completed

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

ℹ Additional Information

@stackblitz
Copy link

stackblitz bot commented Jul 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 6:19pm
flowbite-svelte-update ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 6:19pm

@fkrauthan fkrauthan changed the title fix: Added events to BottomNavHeaderItem fix: Added events to BottomNavHeaderItem Jul 18, 2023
@shinokada shinokada merged commit ebdcbeb into themesberg:main Jul 18, 2023
4 checks passed
shinokada pushed a commit to shinokada/flowbite-svelte that referenced this pull request Jul 19, 2023
shinokada added a commit that referenced this pull request Aug 9, 2023
* docs(alert): update svgs

* docs(badge): update svgs

* docs(bottom-navigation): update svgs

* docs(banner): update svgs

* docs(button-group): update svgs

* docs(button): update svgs

* docs(card): update svgs

* docs(drawer): update svgs

* docs(dropdown): update svgs

* docs(footer): update svgs

* docs(forms): update svgs

* docs(indicators): update svgs

* docs(list-group): update svgs

* docs(mega-menu): update svgs

* docs(modal): update svgs

* docs(navbar): update svgs

* docs(pagination): update svgs

* docs(popover): update svgs

* docs(rating): update svgs

* docs(dropdown): update svgs

* docs(sidebar): update svgs

* fix: #909 (#911)

* fix: update for flowbite-svelte-icon v0.2.1

* docs(sidebar): update svgs

* docs(speed-dial): update svgs

* chore: flowbite-svelte-icon update

* docs(tabs): update svgs

* docs(timeline): update svgs

* docs(toast): update svgs

* docs(mega-menu): update svgs

* docs(checkbox): update svgs

* docs(file-input): update svgs

* docs(input-field): update svgs

* docs(radio): update svgs

* docs(search-input): update svgs

* docs(select): update svgs

* docs(textarea): update svgs

* docs(blockquote): update svgs

* chore: flowbite-svelte-icon v0.2.4

* docs(heading): update svgs

* docs(alert): update svgs

* docs(link): update svgs

* docs(list): update svgs

* docs(paragraph): update svgs

* docs(toolbar): update svgs

* docs(chevron): update svgs

* chore: remove unnecessary svg icons

* chore: format

* chore: format

* fix: remove hidescript for more lines than set up

* docs(CTA): reduce gap between icon and text in button

* docs(register card): make it wider

* fix: select.md

* fix: workaround for scroll to anchor (#923)

* fix: merge confilicts

* fix: merge confilicts

* fix: merge confilicts

* fix: playwright and lint yaml 1.36.0

* fix: merge confilicts

* fix: merge confilicts

* fix: merge confilicts

* chore(release): 0.39.3

* fix: merge confilicts

* fix: #931 (#932)

* v0.40.0

* chore(release): 0.40.1

* fix: Added events to BottomNavHeaderItem (#941)

* fix: #937 (#943)

* docs: (#900) nesting accordian (#936)

* fix: merge confilicts

* fix: merge confilicts

* fix: merge confilicts

* fix: merge confilicts

* fix: merge confilicts

* chore: add flowbite-svelte-icons

* fix: merging conflict update mega-menu, package.json, paragraph.md

* chore(release): 0.42.0

* feat: update flowbite-svelte-icons to 0.3.5

* fix: fine tuning class

* fix: hr page

---------

Co-authored-by: jjagielka <jjagielka@gmail.com>
Co-authored-by: Zoltán Szőgyényi <zoltan.szogyenyi@gmail.com>
Co-authored-by: Florian Krauthan <fkrauthan@gmx.net>
Co-authored-by: Dhruvil Moradiya <132185979+mdhruvil@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BottomNav the BottomNavHeaderItem event on:click is never fired
2 participants