Fixed carousel not working when only one item, mentionned in #175 #550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an issue with the Carousel component that was mentionned in this issue #175. When there is only one item in the carousel, it's not visible even if
data-carousel-item
is set toactive
.I've added a manual check in _rotate to handle the case when there is only one item. I'm really not sure if that was the best way to fix the issue, but it worked for me.
Changes:
_rotate
function to handle the case when there's only one item in the carousel