Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed carousel not working when only one item, mentionned in #175 #550

Merged

Conversation

Kaz-
Copy link
Contributor

@Kaz- Kaz- commented May 9, 2023

I encountered an issue with the Carousel component that was mentionned in this issue #175. When there is only one item in the carousel, it's not visible even if data-carousel-item is set to active.

I've added a manual check in _rotate to handle the case when there is only one item. I'm really not sure if that was the best way to fix the issue, but it worked for me.

Changes:

  • Update _rotate function to handle the case when there's only one item in the carousel

@keerl
Copy link

keerl commented Sep 1, 2023

Is there a reason this hasn't been merged in? I have many pages with dynamic content and sometimes the carousel only has 1 image and it currently doesn't work.

@kirkbushell
Copy link

Who knows, they requested on the thread to provide PRs, but they seem to be really, really slow to managing them...

@zoltanszogyenyi
Copy link
Member

Hey @kirkbushell,

Will have a look at this on Wednesday - we are managing issues and PRs. The sheer number of them are difficult to handle, but regardless we are pushing updates and fixes regularly to the open-source library. We're looking out for a front-end software developer to help us better triage the issues for next year.

Happy holidays!
Zoltan

@seasandf88
Copy link

Is there a reason this hasn't been merged in? I have many pages with dynamic content and sometimes the carousel only has 1 image and it currently doesn't work.

Me too!, merge this fix please.

@zoltanszogyenyi zoltanszogyenyi merged commit 20c7ef5 into themesberg:main Jan 11, 2024
@kirkbushell
Copy link

🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants