⚡ Support webpack 5 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reece Dunham <me@rdil.rocks>
RDIL
commented
Feb 10, 2021
| @@ -36,7 +36,7 @@ | |||
| "stats": "NODE_ENV=development webpack --profile --json > compilation-stats.json" | |||
| }, | |||
| "engines": { | |||
| "node": ">=4.2.4" | |||
| "node": ">=10.13.0" | |||
There was a problem hiding this comment.
To comply with webpack's required version
|
@RDIL thanks for the merge request, I will be handling it over the weekend |
themgoncalves
approved these changes
Feb 14, 2021
|
@RDIL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Reece Dunham me@rdil.rocks
Summary
I've also already published a package based on my fork, so if you don't want to merge this that is fine.
Why
webpack 5 is the next big upgrade for facebook/docusaurus, so this is needed.
Checklist
errorsorwarningsapproved terminologyunit tests, if apply.Emojis for categorizing pull requests:
⚡️ New feature (
:zap:)🐛 Bug fix (
:bug:)🔥 P0 fix (
:fire:)✅ Tests (
:white_check_mark:)🚀 Performance improvements (
:rocket:)🖍 CSS / Styling (
:crayon:)♿ Accessibility (
:wheelchair:)🌐 Internationalization (
:globe_with_meridians:)📖 Documentation (
:book:)🏗 Infrastructure / Tooling / Builds / CI (
:building_construction:)⏪ Reverting a previous change (
:rewind:)♻️ Refactoring (like moving around code w/o any changes) (
:recycle:)🚮 Deleting code (
:put_litter_in_its_place:)