Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FunctionScheduler #22

Closed
themightyoarfish opened this issue Oct 30, 2018 · 1 comment
Closed

Remove FunctionScheduler #22

themightyoarfish opened this issue Oct 30, 2018 · 1 comment

Comments

@themightyoarfish
Copy link
Owner

Since epoch has an arbitrary meaning for PyTorch's schedulers, I believe we don't need the hacky FunctionScheduler if we want to do epoch-based LR changes. Simply step() the scheduler only when an epoch ends.
@themightyoarfish
Copy link
Owner Author

Fixed in 8b3dbe8

themightyoarfish pushed a commit that referenced this issue Oct 30, 2018
Remove useless scheduler class (see #22)
8b3dbe8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@themightyoarfish