Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No response data in case of DioError #10

Closed
felixjunghans opened this issue Dec 28, 2022 · 0 comments · Fixed by #11
Closed

No response data in case of DioError #10

felixjunghans opened this issue Dec 28, 2022 · 0 comments · Fixed by #11

Comments

@felixjunghans
Copy link
Contributor

felixjunghans commented Dec 28, 2022

Hi. Thanks for the cool package. I noticed that in case of a DioError the response is not logged.
To fix the error, the following line must be changed.

dio.dart line 49

change
eventList.updated(event..error = err.toNetworkError());

to

eventList.updated(event..error = err.toNetworkError()..response = err.response?.toResponse());

Could you please release a new version with this fix? We would need the response data in case of a DioError.

Edit I have opened a PullRequest (#11) with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants