Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draggable NetworkLoggerButton? #8

Closed
itsJoKr opened this issue Sep 5, 2022 · 2 comments · Fixed by #9
Closed

Draggable NetworkLoggerButton? #8

itsJoKr opened this issue Sep 5, 2022 · 2 comments · Fixed by #9

Comments

@itsJoKr
Copy link

itsJoKr commented Sep 5, 2022

@themisir We use NetworkLoggerButton and sometimes it would obstruct the view/button behind it.

We have a version where onLongPress, the button would enter in drag mode and you can drag it to a better position. Would you approve this kind of change? We would clean it up and make PR?

@themisir
Copy link
Owner

themisir commented Sep 5, 2022

Sure if you have a suggestion we can apply it. Just make sure to not use any third party package for such interaction (I want to keep package tree as small as possible).

@FranMaric
Copy link
Contributor

@themisir I work with @itsJoKr and this is our proposal. Please comment on it

@themisir themisir linked a pull request Sep 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants