Make NetworkLoggerButton draggable #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themisir
requested changes
Sep 7, 2022
This reverts commit b0b7074.
themisir
approved these changes
Sep 8, 2022
|
@themisir Please merge it. I can't because I don't have write access. |
|
Thanks for your contribution :) |
|
@FranMaric just to check, is this going to let through all the long-press and pans into the user app (that's below the overlay)? |
|
@itsJoKr I haven't tested it but I think it won't let through gestures but only for area under the button |
That was the case for my testing as well. Everything worked as expected. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button can sometimes get in the way so simplest solution is to make it draggable. You need to first long press it and then it becomes draggable and you can move it away.
Hope you like the upgrade :)