Make Scan selected text lazy and add Scan text at selection #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
added
kind/enhancement
Kuuuube
force-pushed
the
scan-selected-text
branch
from
915d3c0
to
cb6f254
Compare
Kuuuube
changed the title
Kuuuube
changed the title
jamesmaa
reviewed
May 14, 2024
| @@ -119,6 +119,7 @@ export class Frontend { | |||
|
|
|||
| this._hotkeyHandler.registerActions([ | |||
| ['scanSelectedText', this._onActionScanSelectedText.bind(this)], | |||
| ['scanTextAtSelection', this._onActionScanTextAtSelection.bind(this)], | |||
There was a problem hiding this comment.
Honestly if renaming is possible I would rather name the current scanSelectedText to scanTextGreedy and repurpose scanSelectedText for this new functionality. I'm not sure about the naming of "lazy" tbh
There was a problem hiding this comment.
Thought about naming them like that but I feel like "greedy" and "lazy" aren't as well known terms to end users.
scanSelectedText just scans the selected text, simple.
scanTextAtSelection scans the text starting at the selection and does whatever it wants inside or outside the selection.
There was a problem hiding this comment.
Oh yeah these are user facing strings 🤔
jamesmaa
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
Scan selected textkeyboard shortcut ignores the selection if it finds a word bigger than the selection. It makes more sense thatScan selected textwould only scan the selected text and not expand outside of it.To not break existing use cases of the previous
Scan selected textI've addedScan text at selectionwhich has the previous behavior and is more in line with what would be expected of that name.Fixes #792