Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow scanning while mouse is not moving if input, textarea, or editable elements are active #958

Merged
merged 2 commits into from
May 17, 2024

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented May 17, 2024

Should help prevent unintended scanning while a user is typing and hits the shift key and the scan key is the shift key.

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels May 17, 2024
@Kuuuube Kuuuube requested a review from a team as a code owner May 17, 2024 14:47
Copy link
Member

@StefanVukovic99 StefanVukovic99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, would just move all these new lines to a method with an explanatory name, and leave here just smth like

if (this._inputtingText()) return;

@Kuuuube
Copy link
Member Author

Kuuuube commented May 17, 2024

Fixed

@jamesmaa jamesmaa added this pull request to the merge queue May 17, 2024
Merged via the queue into themoeway:master with commit e19204b May 17, 2024
10 checks passed
jamesmaa pushed a commit that referenced this pull request May 21, 2024
…itable elements are active (#958)

* Disallow scanning while mouse is not moving if input, textarea, or editable elements are active

* Move to _inputtingText method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants