Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix props type annotation #341

Merged
merged 7 commits into from
Dec 31, 2023
Merged

Fix props type annotation #341

merged 7 commits into from
Dec 31, 2023

Conversation

frorong
Copy link
Collaborator

@frorong frorong commented Dec 31, 2023

개요 💡

props type 지정 방식의 일관성을 맞췄습니다.

작업내용 ⌨️

  1. React.FC 없이 component의 props type을 지정하는 경우 React.FC로 수정했습니다.
interface A { ... };
const C = ({...}: A) => ...
interface A { ... };
const C:React.FC<A> = (...) => ...
  1. props를 받지 않는 컴포넌트에 React.FC가 붙어있는 경우, 이를 생략했습니다.
const C:React.FC = () => ...
const C = () => ...

Copy link

vercel bot commented Dec 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
admin-hello-gsm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2023 9:32am
hello-gsm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2023 9:32am
test-hello-gsm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2023 9:32am
test-hello-gsm-admin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2023 9:32am

…x.tsx

Co-authored-by: 유시온 <rsy5487@naver.com>
@frorong frorong merged commit 4cc3ed8 into develop Dec 31, 2023
5 checks passed
@frorong frorong deleted the fix/props branch December 31, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants